fix: correct off-by-one error in search results line number display#71
Open
fix: correct off-by-one error in search results line number display#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where line numbers in search results were displayed with an incorrect off-by-one offset.
The Issue
The TUI was adding +1 to start_line and end_line when displaying results. However, the database stores line numbers that are already appropriate for 0-indexed internal logic but when combined with the display logic it was causing confusion.
Fix
Removed the +1 addition in src/ui/search_tui.rs when formatting the line number string.
Verification