fix: multiple cortex engine bugs (permissions, markdown, turn_count)#142
Open
redlittenyoth wants to merge 4 commits intoCortexLM:mainfrom
Open
fix: multiple cortex engine bugs (permissions, markdown, turn_count)#142redlittenyoth wants to merge 4 commits intoCortexLM:mainfrom
redlittenyoth wants to merge 4 commits intoCortexLM:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
redlittenyoth
changed the title
…wnload logic - Fix re-entrant deadlock in Context::add_message by using non-recursive compaction - Improve DNS resolution security by failing closed on resolution errors - Fix gopls downloader to use Go proxy since it's not a standard GitHub release - Add missing handlers for protocol operations and event messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three issues in the Cortex engine:
can_load_skill()now correctly honors parent session permissions when inheritance is enabled.turn_countcalculation during message removal, insertion, and truncation inConversation.Fixes: PlatformNetwork/bounty-challenge#8943
Fixes: PlatformNetwork/bounty-challenge#8859
Fixes: PlatformNetwork/bounty-challenge#8881