Chrome: Overwrite existing window + bump to jquery 2 and chrome manifest v2 #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all thanks for your work. The plugin is great!
I changed the chrome version a bit.
The main minor problem of Your plugin was that i couldn't keep my saved windows organised. Every saved window was a new entry so in time there was many different copies of the same window.
I added Overwrite saved window feature.
It works like this.
If You have saved window with specific name, and you want to save new window with the same name (perhaps with different tabs opened). After you click on save button, plugin will ask you if you want to overwrite existing entry.
If you confirm, old entry is removed, and new one is saved with the old name.
It works good for me, so if You want to pull this feature feel free to do that.
I had to upgrade plugin manifest to version: 2 that's why i had to put all js code in external files.
I also bumped up versions of:
jquary to v2
jquaryui to newest.
PS. I know the code is hard to follow, due to huge changes. And i know that this could be done better, but that is what suits me, and i have no more time to spare ;)
Regards,
bhrt