Skip to content

Fix MarkdownTextBlock which is not working in multithreaded #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wherewhere wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MarkdownTextBlock which is not working in multithreaded #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2429141
Let MarkdownConfig.Default supports multithreaded
wherewhere Jan 20, 2026
9cdd6e8
Use CreateDefaultValueCallback to create MarkdownConfig
wherewhere Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/MarkdownTextBlock/src/MarkdownConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@ public record MarkdownConfig
public ISVGRenderer? SVGRenderer { get; set; }
public MarkdownThemes Themes { get; set; } = MarkdownThemes.Default;

public static MarkdownConfig Default = new();
[ThreadStatic]
private static MarkdownConfig? _default;
public static MarkdownConfig Default => _default ??= new MarkdownConfig();
}
2 changes: 1 addition & 1 deletion components/MarkdownTextBlock/src/MarkdownTextBlock.Properties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public partial class MarkdownTextBlock
nameof(Config),
typeof(MarkdownConfig),
typeof(MarkdownTextBlock),
new PropertyMetadata(new MarkdownConfig(), OnConfigChanged)
PropertyMetadata.Create(() => MarkdownConfig.Default, OnConfigChanged)
);

/// <summary>
Expand Down
4 changes: 3 additions & 1 deletion components/MarkdownTextBlock/src/MarkdownThemes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ namespace CommunityToolkit.WinUI.Controls;

public sealed class MarkdownThemes : DependencyObject
{
internal static MarkdownThemes Default { get; } = new();
[ThreadStatic]
private static MarkdownThemes? _default;
internal static MarkdownThemes Default => _default ??= new MarkdownThemes();

public Thickness Padding { get; set; } = new(8);

Expand Down
Loading