Skip to content

Added possibility to give items through car windows#83

Open
tugamars wants to merge 2 commits intoCommunityOx:mainfrom
tugamars:main
Open

Added possibility to give items through car windows#83
tugamars wants to merge 2 commits intoCommunityOx:mainfrom
tugamars:main

Conversation

@tugamars
Copy link

In the current iteration of inventory, giving items through windows of vehicles is not possible: i.e. if player A is near the driver window and player B is sitting in driver seat.

This PR adds that (along with CommunityOx/ox_lib#88 ) as a feature.

Signed-off-by: Marcelo Silva <25794492+tugamars@users.noreply.github.com>
@Skryptific
Copy link

I would remove the parentheses and semicolons to keep the same code style. Other than that, nice addition.

Signed-off-by: Marcelo Silva <25794492+tugamars@users.noreply.github.com>
@tugamars
Copy link
Author

I would remove the parentheses and semicolons to keep the same code style. Other than that, nice addition.

Old habits... Updated it, thank you!

@Maximus7474
Copy link
Member

So to confirm, this PR requires CommunityOx/ox_lib#88 to be merged to be fully functional ?

@tugamars
Copy link
Author

So to confirm, this PR requires CommunityOx/ox_lib#88 to be merged to be fully functional ?

Yes.
If only the ox_inventory pull is merged, it will allow flow from Player in car > Player out of car, but for Player out of car > Player in car it will not work all the time, only in some vehicles (depending on length).

@Maximus7474
Copy link
Member

Sounds good, I'll try and find a bit of time to review the ox_lib PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants