Skip to content

Conversation

@webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 11, 2025

Current

  • When window style is changed in settings, the entire app and ComfyUI server must be restarted.
  • User can select no, which would require additional handling to clean up invalid state.

Proposed

  • Spawn a replacement window and load the original URL.

┆Issue is synchronized with this Notion page by Unito

@webfiltered
Copy link
Contributor Author

Updated requirements for this PR (from rebases) - this can wait for frontend PR to land.

@comfy-pr-bot
Copy link
Member

Test Evidence Check

⚠️ Warning: Test Explanation Missing

If this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.

You can add it by:

  • GitHub: Drag & drop media directly into the PR description
  • YouTube: Include a link to a short demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants