Issue/9057 super user cannot run collectors#799
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to address an issue where super users cannot run collectors by modifying the ModuleInstallation class to be subject to profile-based permissions. However, the PR also includes several unrelated changes.
Changes:
- Added
grant_by_profilecategory to ModuleInstallation class and added it to the AdminSysReadOnly group for SuperUser profile - Added new permissions for Ticketing and Incident groups in the SuperUser profile
- Added row-gap styling to multi-column layout component
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup/moduleinstallation.class.inc.php | Adds grant_by_profile category to make ModuleInstallation subject to profile-based permissions |
| datamodels/2.x/itop-profiles-itil/datamodel.itop-profiles-itil.xml | Adds ModuleInstallation to AdminSysReadOnly group; adds unrelated Ticketing and Incident permissions |
| css/backoffice/layout/multi-column/_multi-column.scss | Adds row-gap styling to multi-column layout (unrelated UI improvement) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $aParams = | ||
| [ | ||
| "category" => "core,view_in_gui", | ||
| "category" => "core,view_in_gui,grant_by_profile", |
There was a problem hiding this comment.
The PR description template has not been filled out. The description should explain:
- What the symptom/objective is (why super users cannot run collectors)
- The reproduction procedure
- The root cause of the issue
- How this change fixes it
- Why multiple seemingly unrelated changes (ModuleInstallation permissions, Ticketing/Incident permissions, and CSS row-gap) are being made in a single PR
Without this information, it's difficult to properly review whether the changes are correct and complete.
|
@v-dumas please assign yourself to your PRs. Also, if you don't fill the template, please remove everything and just put "Internal". |
3 participants
Pull request overview
This PR attempts to address an issue where SuperUser cannot run collectors as it requires to get objects from the ModuleInstallation class.
Changes:
grant_by_profilecategory to ModuleInstallation class and added it to the AdminSysReadOnly group for SuperUser profileReviewed changes
grant_by_profilecategory to make ModuleInstallation subject to profile-based permissions