N°9009 Add phpunit test to GetSelectedModules#792
Open
Timmy38 wants to merge 1 commit intofeature/uninstallationfrom
Open
N°9009 Add phpunit test to GetSelectedModules#792Timmy38 wants to merge 1 commit intofeature/uninstallationfrom
Timmy38 wants to merge 1 commit intofeature/uninstallationfrom
Conversation
rquetiez
requested changes
Jan 9, 2026
| 'aExpectedModules' => [], | ||
| 'aExpectedExtensions' => [], | ||
| ], | ||
| 'One extension selected' => [ |
Contributor
There was a problem hiding this comment.
Independently from the implementation, we should have tests scenarios with multiple extensions selected
| public function ProviderGetSelectedModules() | ||
| { | ||
| return [ | ||
| 'No extension selected' => [ |
Contributor
There was a problem hiding this comment.
I wonder : do we have other cases with different conditions and same result? How about having test cases with exclusive options ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.