N°8921 - feat(AttributeLinkedSet): Allow for export in Spreadsheet HTML format#759
Open
Hipska wants to merge 6 commits intoCombodo:developfrom
Open
N°8921 - feat(AttributeLinkedSet): Allow for export in Spreadsheet HTML format#759Hipska wants to merge 6 commits intoCombodo:developfrom
Hipska wants to merge 6 commits intoCombodo:developfrom
Conversation
…low for export in Spreadsheet HTML format
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
jf-cbd
moved this from Hacktoberfest
to Pending technical review
in Combodo PRs dashboard
jf-cbd
moved this from Pending technical review
to Pending functional review
in Combodo PRs dashboard
jf-cbd
changed the title
Member
|
Hey @Hipska, thank you for your PR. It seems nice, but why IDs are exported when the object isn't localised ? Shouldn't it be only when there is no friendly name ? |
jf-cbd
moved this from Pending functional review
to Pending technical review
in Combodo PRs dashboard
Contributor
Author
|
This was to keep backward compatibility. If somebody relied on having the IDs, then they should still be there when using no localisation. |
# Conflicts: # core/spreadsheetbulkexport.class.inc.php # sources/Core/AttributeDefinition/AttributeLinkedSet.php
Hipska
force-pushed
the
feat/attributelinkedset/csv_export
branch
from
5be624d to
cf30917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Objective
Exporting a
LinkedSetattribute with spreadsheet HTML just returns the list of IDs of the linked objects, which is not very helpful for further processing.Proposed solution
Checklist before requesting a review