fix(modal-infra): exit gracefully on HTTP 410 instead of retrying forever #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever Previously, when the control plane returned HTTP 410 (session terminated), the bridge would retry indefinitely with exponential backoff. This happened after deployments or inactivity timeouts when the session was marked as stopped/stale. Now the bridge recognizes fatal HTTP errors (410, 401, 404) and exits cleanly, allowing Modal to shut down the container. Users can restore sessions by sending a new prompt, which triggers snapshot restoration. Changes: - Add SessionTerminatedError for non-recoverable session termination - Handle InvalidStatus exception to catch HTTP rejection at connect time - Add _is_fatal_connection_error() as fallback for string-based detection - Add unit tests for error handling logic
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
Greptile OverviewGreptile SummaryPrevents infinite retry loop when control plane terminates sessions by catching HTTP 410/401/404 errors and exiting gracefully instead of retrying.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Add HTTP 403 (Forbidden) to fatal error patterns - Use defensive getattr() chain for InvalidStatus response access - Add test for HTTP 403
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
After deployments or inactivity timeouts, sandboxes would see this pattern indefinitely:
The control plane correctly returns 410 when a session is stopped/stale, but the bridge didn't recognize this as a terminal state.
Solution
SessionTerminatedErrorexception for non-recoverable session terminationInvalidStatusexception to catch HTTP rejection at WebSocket connect time_is_fatal_connection_error()as fallback for string-based detectionTest plan
_is_fatal_connection_error()covering fatal and non-fatal casesSessionTerminatedErrorexception behavior