London | 26-ITP | Abdul Moiz | Sprint 1 | Wireframe

[A-Moiz]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Removed answers.html
• Made relevant changes in index.html
• Removed changes in README.md
• Removed inline CSS and used external CSS

Questions

N/A

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	8181b0a
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/696e9bd72be4c5000896e6ca
😎 Deploy Preview	https://deploy-preview-938--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 96 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[A-Moiz]

Added Needs Review Label

[A-Moiz]

Undid changes in /Form-Controls

[jenny-alexander]

Hey @A-Moiz! Thanks for submitting a PR for the wireframe exercise. I noticed a few things to change:

1. You made your changes in a new file answers.html. You should be making changes directly in index.html. Can you remove the answers.html file from this PR? Here is what the exercise says:
   There are some provided HTML and CSS files you can use to get started. You can use these files as a starting point or create your own files from scratch. You must modify the HTML and CSS files to meet the acceptance criteria and you must check this criteria yourself before you submit your work.

2. The README file should not be included in this PR.
   I think you probably wanted to check off the steps needed within the Learner Template section of this PR?
   If yes, then click on the ellipsis (3 dots), and choose edit.

[A-Moiz]

Hi, @jenny-alexander I made the changes you mentioned, let me know if everything is all good now or if anymore changes are needed, thanks.

[jenny-alexander]

Thanks for making your changes directly within the index.html file.
After reviewing your PR again, I see opportunities for improvement.

1. Can you remove the placeholder image and insert an image that is related to the article?
2. Can you make sure that when a user clicks on the 'Read More' button, they are brought to a webpage/article with information about the article?

I left a few other comments for you to address.

[jenny-alexander]

Can you review the exercise requirements concerning where the styling should be done?
https://github.com/CodeYourFuture/Module-Onboarding/tree/main/Wireframe#acceptance-criteria

[A-Moiz]

Hi @jenny-alexander , I added links to relevant articles alongside relevant images.

[jenny-alexander]

Can you review the assignment requirements? I only see 3 questions that need to be answered, but you mentioned a 4th question about the article tag that isn't in the instructions.

[A-Moiz]

Hi, I removed that extra article. I must've mistaken it for another task by accident.

[jenny-alexander]

For the footer section:

• Can you review the exercise requirements concerning where the styling should be done (CSS or in index.html file)?
  https://github.com/CodeYourFuture/Module-Onboarding/tree/main/Wireframe#acceptance-criteria
• Can you review the appearance of the footer? Right now, it's hard to read the text of the footer because there isn't a background color to the footer. Perhaps you can find a different way to style it? 🙂

[A-Moiz]

Hi, I was 100% sure on what you means by the appearance of the Footer but to be sure I added a background colour of white and changed the font weight of the text.

[A-Moiz]

Updated index.html and style.css based on comments received.

[jenny-alexander]

All requested changes have been made nicely @A-Moiz - good work!