fix: some yul commands cause compile error (iszero, eq, etc)#2
Open
Taewa wants to merge 1 commit intoCodeForcer:mainfrom
Open
fix: some yul commands cause compile error (iszero, eq, etc)#2Taewa wants to merge 1 commit intoCodeForcer:mainfrom
Taewa wants to merge 1 commit intoCodeForcer:mainfrom
Conversation
|
Would be good to merge it , had the same issue |
Author
In order to merge it, I need maintainer's approval, right? |
flyq
reviewed
Jul 24, 2023
Contributor
flyq
left a comment
There was a problem hiding this comment.
--yul Switch to Yul mode, ignoring all options except
--machine, --yul-dialect, --optimize and
--yul-optimizations and assumes input is Yul.
--strict-assembly Switch to strict assembly mode, ignoring all options
except --machine, --yul-dialect, --optimize and
--yul-optimizations and assumes input is strict
assembly.is the error caused by iszero is a strict assembly, not Yul?
Author
Yes I experienced the error I mentioned above with |
flyq
approved these changes
Jul 28, 2023
Author
|
@flyq thanks for the approval. Do I have right to merge or someone else should merge it? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge testthrow an error due to the some of yul functions such asiszerooreq, etc.I will leave here an example code in order to reproduce the issue.
and test code
the error: