Port Diana Gergel's QPLAD from CIL xclim fork#197
Draft
brews wants to merge 3 commits intoClimateImpactLab:mainfrom
Draft
Port Diana Gergel's QPLAD from CIL xclim fork#197brews wants to merge 3 commits intoClimateImpactLab:mainfrom
brews wants to merge 3 commits intoClimateImpactLab:mainfrom
Conversation
Adds Diana Gergel's code (from fork ClimateImpactLab/xclim@63023d2 ) to implement QPLAD downscaling with vanilla xclim install.
Member
Author
|
I had to move and rename a few things, but for the most part, the ported code is still intact and unharassed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 89.34% 88.59% -0.76%
==========================================
Files 8 8
Lines 1352 1420 +68
==========================================
+ Hits 1208 1258 +50
- Misses 144 162 +18 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a port of @dgergel's
QuantilePreservingAnalogDownscalingfor QPLAD downscaling.This is ported from a ClimateImpactLab fork of
xclim.Porting this code lets us run QPLAD in dodola without depending on pip-installing an old fork of
xclim, instead, installingxclimfrom conda-forge. A xclim=0.30.1 dependency from conda-forge was added to environment.yaml because I think this is the last version thexclimfork synced from https://github.com/Ouranosinc/xclim. v0.30.1 ofxclimwas released Oct 1st, 2021. Currently, the latest version ofxclimis v0.36.0.