Merged
Conversation
…for shooting methods
…th static goal and cost matrices
alberthli
commented
Dec 4, 2023
alberthli
commented
Dec 4, 2023
alberthli
commented
Dec 4, 2023
alberthli
commented
Dec 5, 2023
vincekurtz
requested changes
Dec 5, 2023
Collaborator
vincekurtz
left a comment
There was a problem hiding this comment.
Overall API looks good, just missing a few tests.
I would add tests for:
- Computing the cost for quadratic with static goal (vs for loop)
- Computing the gradient and Hessian for the quadratic with static goal (vs autodiff)
- A smoke test for creating a
VanillaPredictiveSamplerand callingoptimize(maybe not necessary depending on below) - Some sanity check that predictive sampling is doing the right thing. That could be a pendulum swingup example (should work even if the implementation isn't blazing fast yet) or a little unit test that shows the cost generally going down, or something else.
Contributor
Author
|
Agreed on the first two requested tests - those should be trivial to spin up. Sanity check of choice: randomly sample a batch of initial policies and also shoot them forward. pass those guesses to vanilla predictive sampling, which returns new trajectories that should be no worse than the guesses. verify this property in a test. TODO list:
|
alberthli
commented
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a very generic and flexible API for trajectory optimization. As a specific instantiation, it also implements the extremely simple predictive sampling algorithm.