Optimize refreshing of objects' list#104
Open
sulfasTor wants to merge 4 commits intoCSAILVision:masterfrom
Open
Optimize refreshing of objects' list#104sulfasTor wants to merge 4 commits intoCSAILVision:masterfrom
sulfasTor wants to merge 4 commits intoCSAILVision:masterfrom
Conversation
added 4 commits
August 31, 2019 11:24
When an object is deleted updates it status in the list.
Updates the object's name on the list instead of recreating it
Each function calling StopEditEvent() calls also RenderObjectList. Removing these lines avoids recreating the object list twice. This can be problematic when updating hundreds of objects.
This function refreshes the object list modifying only the DOM element who was deleted or it name changed.
|
@quantombone , @adikhosla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating hundreds of objects it lags amazingly because of the object list being recreated each time a little modification is detected.
This pull request optimizes the refreshing which reduces the lag by 200%.