Fix pmtentry clean #1988
Open
Fix pmtentry clean #1988
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 477307e...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 477307e...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Contributor
Author
|
@cfsmp3 please review this PR |
cfsmp3
added a commit
that referenced
this pull request
Jan 10, 2026
Delete the unused `impl FromCType<*mut PMT_entry> for *mut PMTEntry` implementation which had a critical bug: it returned a pointer to a stack-allocated PMTEntry, causing undefined behavior (dangling pointer). This code was never called anywhere in the codebase. The actual usage in demuxer.rs uses the value-returning variant `FromCType<PMT_entry> for PMTEntry` with explicit `Box::into_raw(Box::new(...))` wrapping, which is the correct pattern. Rather than fixing dead buggy code, just remove it. Supersedes #1988 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] Critical Rust FFI memory safety: avoid returning pointer to stack-allocated PMTEntry
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Description
PR fixes a use-after-scope (dangling pointer) bug in the Rust FFI layer.
The implementation of:
previously returned a raw pointer derived from a stack-allocated PMTEntry.
Once the function returned, the stack frame was destroyed, leaving the pointer
dangling and causing undefined behavior in Rust.
This is a correctness and memory-safety issue independent of C-side usage,
tests, or call order.
Fixes #1986