Fix bad method names in README (getclass and get_type)#37
Open
Giorgiolino wants to merge 2 commits intoBurgov:masterfrom
Open
Fix bad method names in README (getclass and get_type)#37Giorgiolino wants to merge 2 commits intoBurgov:masterfrom
Giorgiolino wants to merge 2 commits intoBurgov:masterfrom
Conversation
The `getclass($data)` call should be rewritten to `get_class($data)` (cf. https://www.php.net/get-class)
The `get_type($data)` call should be rewritten to `gettype($data)` (cf. https://www.php.net/gettype)
Giorgiolino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getclass($data)call should be rewritten toget_class($data)(cf. https://www.php.net/get-class).
The
get_type($data)call should be rewritten togettype($data)(cf. https://www.php.net/gettype)
Otherwise, it would result in the following Fatal Error (for getclass)
PHP Fatal error: Uncaught Error: Call to undefined function getclass()