Local Docker build fails when amazon-blc module is added to pom#26
Open
frostyandy2k wants to merge 5 commits intoBroadleafCommerce:develop-3.0.xfrom
Open
Local Docker build fails when amazon-blc module is added to pom#26frostyandy2k wants to merge 5 commits intoBroadleafCommerce:develop-3.0.xfrom
frostyandy2k wants to merge 5 commits intoBroadleafCommerce:develop-3.0.xfrom
Conversation
Author
|
¡ this may be due to something else in our system ! Will add updates shortly. |
Author
|
BLC does not crash in a docker environment when adding the amazon-blc module. The issue was due to runtime executable that wrongly interpreted the AWS_ACCOUNT_ALIAS variable. Still, it would be useful to be able to toggle the module on or off for local testing as is done in this PR. |
This was referenced Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Brief Overview
I have encountered an issue with the amazon-blc module.
It creates a bean no matter if we need it or not and in turn tries to see if there are any valid credential providers. This causes the admin and site to crash in a local docker container: