Open
Conversation
added 6 commits
February 28, 2017 17:30
pllearns
reviewed
Mar 3, 2017
pllearns
left a comment
pllearns
left a comment
There was a problem hiding this comment.
Solid work so far! I like your approaches to refactoring and I love seeing how much you have picked up along the way.
| let diamondLimit = alphabet.slice(0, alphabet.indexOf(letter)+1).split('') | ||
| let diamondArray = [] | ||
|
|
||
| // for (let i = 0; i < alphabet.length; i++) { |
There was a problem hiding this comment.
Is there a reason why you are keeping this commented code here?
| return true; | ||
| } | ||
| return false; | ||
| return firstStrand.length === secondStrand.length ? true : false |
| } | ||
| } | ||
| return hammingDistance | ||
| return firstStrand.split('').reduce( function(accumulator, current, index){ |
There was a problem hiding this comment.
I am really liking your approach. Reduce is going to be with us for quite a while in JavaScript.
| } | ||
|
|
||
| let largestProduct = 0 | ||
| for (let i = 0; i <= this.number.length-seriesNumber; i++) { |
There was a problem hiding this comment.
can you place a space in between this.number.length, seriesNumber, and the -?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.