Conversation
| var Bob = function() {}; | ||
|
|
||
| Bob.prototype.hey = function(what) { | ||
| if (/([A-Z]+\s){2,}|[A-Z](?=!)/.test(what)) { |
There was a problem hiding this comment.
Good use of RegExp, especially the lookahead 👍
| var result = bob.hey('\xdcML\xc4\xdcTS!'); | ||
|
|
||
| var result = bob.hey('\xdcML\xc4\xdcTS!'); |
There was a problem hiding this comment.
I'm curious what the intention of this test and the special characters test above it are. Both of those tests have ordinary capitalized letters followed by exclamation marks, which should match the RegExp regardless of whether the special characters match.
I know you didn't write it, I'm just not sure that it's testing anything different than the other cases and wanted to point that out. 😋
| var SecretHandshake = function(input) { | ||
| if (typeof input !== 'number') { | ||
| throw new Error('Handshake must be a number') | ||
| } |
| var bracket = function(input) { | ||
| //define what ending bracket should be if the beginning is found | ||
| }; | ||
|
|
There was a problem hiding this comment.
You should try to keep incomplete placeholders like this out of commits for complete tests, that way you have more freedom to cherry pick commits later or reorder them during a rebase without ending up with files getting reverted to a broken state.
Personally I try to make a separate commit for each change (ex: secret handshake would be a different commit from bob, and bob's commit would never have changes to secret handshake's files) but that's just one way of keeping git stuff organized.
2 participants
No description provided.