fix: include current cycle in getCurrentVotingPower #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change getCurrentVotingPower to calculate voting power from previousCycleStartingBlock to block.number instead of just to lastClaimedBlockNumber. This ensures users who hold BREAD in the current cycle have their voting power counted.
Collaborator
Author
|
reccomending merging this in and setting the minimum voting power to 0 to allow for instant voting @bagelface we wil need to do another upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getCurrentVotingPowerto include voting power from the current cycle, not just the previous cyclelastClaimedBlockNumbertoblock.numberThis resolves the issue where users who hold BREAD in the current cycle would see 0 voting power returned.
Test plan
getCurrentVotingPowerreturns non-zero for users with BREAD in current cycle🤖 Generated with Claude Code