Open
Conversation
Trivial wrapper around `VecDequeue`, with methods and C API matching the asf4 utils_ringbuffer.h. With a similar API, we can replace all uses of it easily. The C ringbuffer was fixed size and not heap allocated, and `VecDequeue` is dynamic and heap allocated. We simply panic once we go above the "fixed" size to avoid filling up the whole RAM in case of a bug.
benma
force-pushed
the
rust-ringbuffer
branch
from
02fd060 to
6f5a618
Compare
benma
force-pushed
the
rust-ringbuffer
branch
from
6f5a618 to
c5842bb
Compare
Collaborator
|
Did you test upgrading firmware over BLE? I'm curious if performance was impacted in any way. |
Collaborator
Author
Great point, I didn't consider performance. I did a direct comparison now (with and without the commits of this branch, Nova bootloader) and the fw flashing was exactly the same speed - 1m53s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested: