Open
Conversation
NickeZ
force-pushed
the
maint/tune-qtouch
branch
5 times, most recently
from
6237122 to
0783a54
Compare
Collaborator
|
Commit qtouch: switch PTC to 8Mhz clock from 12 Mhz is changing a bunch of configs that seem unrelated to the PTC rate. Please explain them too in the commit msg. |
benma
reviewed
Sep 23, 2025
src/qtouch/qtouch.c
Outdated
| bool qtouch_is_scroller_active(uint16_t sensor_node) | ||
| { | ||
| return scroller_active[scroller]; | ||
| return scroller_active[sensor_node]; |
Collaborator
There was a problem hiding this comment.
rename scroller_active too, or keep the param name scrollerr, for consistency?
Collaborator
Author
It is all related, I enable and configure clock number 5 and I configure the ADC/PTC to use that new clock. |
NickeZ
force-pushed
the
maint/tune-qtouch
branch
3 times, most recently
from
d4e7409 to
f4d7131
Compare
8Mhz is recommended by the tooling and can be divided down to the required 2Mhz with the ADC prescaler
The qtouch configurator has changed the default output to not use the binding layer. Let's remove it to be more in sync with the configurator. No functionality is lost. All changes come from the new templates.
NickeZ
force-pushed
the
maint/tune-qtouch
branch
3 times, most recently
from
3b7aafe to
96edfb9
Compare
* Lower the ADC/PTC frequency to 2Mhz * Lower the analog gain as that introduces more noise * Higher analog gain of edge sensors that are less sensitive * Make filter 8x digital gain as per recommendation * Reduce threshold for active to 12 (to be tweaked) * Put sensor groups in AKS groups so that if one sensor is active no other sensor in the same group can become active. * Reduce hysteris to 25% to make "untouch" quicker * Speed up all calibration rates to 1 step per 200ms * Remove force calibrate. The faster calibration rates should fix the sensors equally quick. * Add all functions from templates that was missing to make future diffs with atmel start smaller.
NickeZ
force-pushed
the
maint/tune-qtouch
branch
from
96edfb9 to
a0597ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.