Merged
Conversation
Contributor
|
Thank you very much for the PR! |
talhaHavadar
approved these changes
Feb 27, 2026
Contributor
talhaHavadar
left a comment
talhaHavadar
left a comment
There was a problem hiding this comment.
Looking good and builds fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nix build wasn't actually working. The
fetchFromGitHubhad a placeholder hash so it could never fetch, and there were some dep issues blocking the build.Switched to building from local source, relaxed the pyftdi version pin so it plays nice with nixpkgs, dropped the unused pyudev dep, and added mainProgram so nix run works. Also bumped the version to 0.3.1 and cleaned up some unused args.