Skip to content

Conversation

@reedy
Copy link
Contributor

@reedy reedy commented Nov 18, 2025

Also alphasort list

@DASPRiD
Copy link
Member

DASPRiD commented Nov 18, 2025

Can you quickly explain, why those need to be in gitattributes?

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.81%. Comparing base (283e2dd) to head (791a776).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #213   +/-   ##
=========================================
  Coverage     70.81%   70.81%           
  Complexity      994      994           
=========================================
  Files            49       49           
  Lines          3169     3169           
=========================================
  Hits           2244     2244           
  Misses          925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reedy
Copy link
Contributor Author

reedy commented Nov 18, 2025

Can you quickly explain, why those need to be in gitattributes?

Because they're not needed for people using the library (when installed via composer).

AFAIS, the packages (if installed) are only for testing purposes?

@DASPRiD
Copy link
Member

DASPRiD commented Nov 18, 2025

Ah yes, good point. Could you update the PR and also remove the Dockerfile? that one was removed from the repo.

@DASPRiD
Copy link
Member

DASPRiD commented Nov 18, 2025

Also, I assume this change can be considered a chore and not a fix (so it doesn't warrant a patch release by itself)?

@reedy
Copy link
Contributor Author

reedy commented Nov 18, 2025

Also, I assume this change can be considered a chore and not a fix (so it doesn't warrant a patch release by itself)?

I wouldn't complain if you did a point release for it, both files are relatively small... Some repos end up with large files, which is more annoying when you're committing the output elsewhere for say deployment reasons.

@DASPRiD DASPRiD changed the title .gitattributes: Add package.json and package-lock.json fix: exclude package.json and package-lock.json from git export Nov 19, 2025
@DASPRiD DASPRiD merged commit 470d59f into Bacon:main Nov 19, 2025
8 of 9 checks passed
@williamdes
Copy link
Contributor

Thank you so much for this PR !

@reedy reedy deleted the patch-1 branch November 19, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants