ZYancey/CSBot/18/Smite#415
ZYancey/CSBot/18/Smite#415ZYancey wants to merge 9 commits intozyancey/CSBot/413/TSNativeRoomfinderfrom
Conversation
src/commands/smite.ts
Outdated
| ); | ||
|
|
||
| const ODIN_SMITING_THOR_GIF = | ||
| 'https://cdn.discordapp.com/attachments/781563734098575410/1083403217553084446/smite.gif?ex=68fb93df&is=68fa425f&hm=83b4a865179f0dd6fb1312f535c2a730673709734470c0095dd2a432908bfcba&'; |
There was a problem hiding this comment.
This link has expired already. We should instead provide the image file directly.
src/commands/smite.ts
Outdated
| const ODIN_SMITING_THOR_GIF = | ||
| 'https://cdn.discordapp.com/attachments/781563734098575410/1083403217553084446/smite.gif?ex=68fb93df&is=68fa425f&hm=83b4a865179f0dd6fb1312f535c2a730673709734470c0095dd2a432908bfcba&'; | ||
| const WACK_IMAGE = | ||
| 'https://i.kym-cdn.com/entries/icons/original/000/033/758/Screen_Shot_2020-04-28_at_12.21.48_PM.png'; |
There was a problem hiding this comment.
This link still works, but feels weird to rely on an external service for a file we may frequently access. We should provide this file directly as well
There was a problem hiding this comment.
maybe even convert to .webp for smaller storage, unless we have ppl using old versions of Safari lol
There was a problem hiding this comment.
I wonder if we should make a simple HTTP server in CSBot that serves static images like these ones 🤔
README.md
Outdated
|
|
||
| ### /unsmite | ||
|
|
||
| **[Admin Only]** Removes the smite status from a user, restoring their ability to use bot commands immediately. |
There was a problem hiding this comment.
| **[Admin Only]** Removes the smite status from a user, restoring their ability to use bot commands immediately. | |
| **[Admin Only by default]** Removes the smite status from a user, restoring their ability to use bot commands immediately. |
src/events/ready.ts
Outdated
|
|
||
| // Set up automatic unsmiting of users after 1 hour | ||
| // This will check every hour and unsmite anyone who has been smitten for over an hour | ||
| setupAutoUnsmiteCron(); // Default: '0 * * * *' (every hour) |
There was a problem hiding this comment.
Since most users won't be smitten exactly at the top of the hour, this may result in users being smitten for at most 1h59m. This may be fine, but the README says "one hour". Should the doc be changed to something like "at least one hour", or should we do the timeout a different way?
/smite
Temporarily prevents a user from using bot commands for one hour. Only administrators can successfully use this command - non-admins who attempt to use it will be smitten for 60 seconds. Administrators cannot be smitten, and attempting to smite the bot will result in the executor being smitten instead. Users who smite themselves receive a special response.