Blue collar PR: Remove superfluous semicolons and convert tabs to spaces#120
Open
javadba wants to merge 3 commits intoBIDData:masterfrom
Open
Blue collar PR: Remove superfluous semicolons and convert tabs to spaces#120javadba wants to merge 3 commits intoBIDData:masterfrom
javadba wants to merge 3 commits intoBIDData:masterfrom
Conversation
…o spaces and removing semicolons
…s - so I rolled that one back.
Contributor
Author
|
Due to (a) no feedback and (b) not being merged in a timely manner by the project maintainers this PR is now out of sync with trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… style CRLF.
This is truly a blue collar PR. Just cleaning up those minor details. The diffs are ugly (huge) because of removing the LineFeeds.
After having rebuilt I have:
manually eyeballed about half the files
rebuilt using sbt package
tried out iscala notebook: seems to be ok
tried out an ssc: it starts to run but can not find data (unrelated usability issue)
If this general approach were acceptable, I will manually traverse the remaining 50 or so files to ensure all look fine. The criteria:
leading tabs to 2 spaces
end-of-line semicolons removed
dos2unix type conversion (though I used a sed command to do it)