-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Upgrade Quota service from API version 2023-02-01 to 2025-09-01 stable
#28902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
…AU/azure-powershell into resilv/group-quota-sept
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
notyashhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Also, can you please add changelog under the ##Upcoming Changes section?
In file Quota/Quota/Changelog.md
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dolauli , @isra-fel , @notyashhh Comments have been addressed and tests now pass in Playback mode. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I have a few small comments. Thank you.
- The
generated/folder doesn't need to be checked in. Please restore them from your PR. - Please see my inline comments as well.
| @@ -70,7 +79,7 @@ directive: | |||
|
|
|||
| # Rename parameter | |||
| - where: | |||
| werb: New | |||
| verb: New | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| verb: New | |
| verb: New|Update |
Update-AzQuota still have this weird parameter name as -NameValue.
| partial void overrideOnDefault(global::System.Net.Http.HttpResponseMessage responseMessage, global::System.Threading.Tasks.Task<Microsoft.Azure.PowerShell.Cmdlets.Quota.Models.IErrorResponse> response, ref global::System.Threading.Tasks.Task<bool> returnNow) | ||
| { | ||
| // Read the response content | ||
| var content = responseMessage.Content.ReadAsStringAsync().Result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment makes sense. Please address it
| # But preserve all variants for subscription/allocation management operations | ||
| - where: | ||
| variant: ^(Create|Update).*(?<!Expanded|JsonFilePath|JsonString)$ | ||
| subject: ^(?!GroupQuotaSubscription|GroupQuotaLimitsRequest|GroupQuotaSubscriptionAllocation).*$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
This PR upgrades the Az.Quota module from API version 2023-02-01 to 2025-09-01 stable, introducing comprehensive Group Quota management capabilities at the management group level. This is a significant enhancement that enables centralized quota governance across multiple subscriptions.
Key Changes:
API Version Upgrade: Migrated from 2023-02-01 to 2025-09-01 stable
New Group Quota Cmdlets: Added 10+ new cmdlets for CRUD operations on group quotas, subscriptions, location settings, limits, allocations, and usage
Documentation: Generated complete help documentation for all new cmdlets
Changes:
Get/New/Update/Remove-AzQuotaGroupQuota)Get/New/Update/Remove-AzQuotaGroupQuotaSubscription)2023-02-01to2025-09-01stableThis enables Azure customers to manage quotas across multiple subscriptions at the management group level for improved governance and resource allocation.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.