Skip to content

Conversation

@RenSilvaAU
Copy link
Contributor

@RenSilvaAU RenSilvaAU commented Nov 19, 2025

Description

This PR upgrades the Az.Quota module from API version 2023-02-01 to 2025-09-01 stable, introducing comprehensive Group Quota management capabilities at the management group level. This is a significant enhancement that enables centralized quota governance across multiple subscriptions.

Key Changes:

  • API Version Upgrade: Migrated from 2023-02-01 to 2025-09-01 stable

  • New Group Quota Cmdlets: Added 10+ new cmdlets for CRUD operations on group quotas, subscriptions, location settings, limits, allocations, and usage

  • Documentation: Generated complete help documentation for all new cmdlets

Changes:

  • Added 10+ new cmdlets for managing group quotas at the management group level:
    • Group quota CRUD operations (Get/New/Update/Remove-AzQuotaGroupQuota)
    • Subscription associations (Get/New/Update/Remove-AzQuotaGroupQuotaSubscription)
    • Quota limit and allocation requests
    • Usage and location settings management
  • Upgraded from API version 2023-02-01 to 2025-09-01 stable
  • Updated AutoRest directives for proper verb mapping (New for PUT-only operations)
  • All tests passing with comprehensive recording files
  • Generated help documentation for all new cmdlets

This enables Azure customers to manage quotas across multiple subscriptions at the management group level for improved governance and resource allocation.

Mandatory Checklist

  • SHOULD updated ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@RenSilvaAU RenSilvaAU self-assigned this Nov 19, 2025
@RenSilvaAU RenSilvaAU requested a review from dolauli November 19, 2025 22:32
@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Also, can you please add changelog under the ##Upcoming Changes section?

In file Quota/Quota/Changelog.md

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings January 27, 2026 23:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings January 28, 2026 01:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@RenSilvaAU
Copy link
Contributor Author

@dolauli , @isra-fel , @notyashhh

Comments have been addressed and tests now pass in Playback mode.

@isra-fel isra-fel assigned isra-fel and unassigned RenSilvaAU Jan 28, 2026
@isra-fel isra-fel added this to the Az 15.4.0 (03/03/2026) milestone Jan 28, 2026
@isra-fel
Copy link
Member

isra-fel commented Feb 9, 2026

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I have a few small comments. Thank you.

  1. The generated/ folder doesn't need to be checked in. Please restore them from your PR.
  2. Please see my inline comments as well.

@@ -70,7 +79,7 @@ directive:

# Rename parameter
- where:
werb: New
verb: New
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
verb: New
verb: New|Update

Update-AzQuota still have this weird parameter name as -NameValue.

partial void overrideOnDefault(global::System.Net.Http.HttpResponseMessage responseMessage, global::System.Threading.Tasks.Task<Microsoft.Azure.PowerShell.Cmdlets.Quota.Models.IErrorResponse> response, ref global::System.Threading.Tasks.Task<bool> returnNow)
{
// Read the response content
var content = responseMessage.Content.ReadAsStringAsync().Result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment makes sense. Please address it

# But preserve all variants for subscription/allocation management operations
- where:
variant: ^(Create|Update).*(?<!Expanded|JsonFilePath|JsonString)$
subject: ^(?!GroupQuotaSubscription|GroupQuotaLimitsRequest|GroupQuotaSubscriptionAllocation).*$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants