[App Service] az webapp update: Add parameter for e2e encryption
#32629
+1,988
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seligj95
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp create | cmd webapp create added parameter end_to_end_encryption_enabled |
||
| webapp create | cmd webapp create added parameter min_tls_cipher_suite |
||
| webapp create | cmd webapp create added parameter min_tls_version |
||
| webapp update | cmd webapp update added parameter end_to_end_encryption_enabled |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for end-to-end encryption configuration to the az webapp update command. The feature allows users to enable or disable encryption between the Front End and Workers in Azure App Service.
Changes:
- Added
--end-to-end-encryption-enabledparameter (with-eshorthand) toaz webapp update - Implemented the parameter handling logic in the webapp update function
- Added comprehensive test coverage for both enabling and disabling the feature
- Minor refactoring of condition check in
update_site_configsfor consistency
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_params.py |
Adds the new --end-to-end-encryption-enabled parameter with -e shorthand option |
custom.py |
Implements the parameter handling in update_webapp function and refactors a condition |
test_webapp_commands.py |
Adds test case for enabling/disabling end-to-end encryption |
test_webapp_update_e2e_encryption.yaml |
Test recording file showing the full test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
please resolve the code conflicts |
Contributor
Author
|
@yanzhudd fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp update -g -n -e
Description
Adding a parameter for end to end encryption as requested by customer
Testing Guide
az webapp update -g -n -e
History Notes
[App Service]
az webapp create/update: Add--end-to-end-encryption-enabledparameter to support enabling or disabling end-to-end encryption between the front end and the workers[App Service]
az webapp create: Add--min-tls-versionparameter to specify the minimum version of TLS[App Service]
az webapp create: Add--min-tls-cipher-suiteparameter to specify the minimum TLS Cipher SuiteThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.