fix: add UTF-8 encoding for subprocess calls on Windows#139
Open
cabana8471-arch wants to merge 1 commit intoAutoForgeAI:masterfrom
Open
fix: add UTF-8 encoding for subprocess calls on Windows#139cabana8471-arch wants to merge 1 commit intoAutoForgeAI:masterfrom
cabana8471-arch wants to merge 1 commit intoAutoForgeAI:masterfrom
Conversation
On Windows, subprocess.Popen/run with text=True defaults to CP1252 encoding instead of UTF-8. This causes UnicodeDecodeError when Claude outputs characters outside the CP1252 codepage. Add explicit encoding="utf-8" and errors="replace" parameters to all subprocess calls that use text=True. Files modified: - parallel_orchestrator.py (3 locations) - start.py (2 locations) - start_ui.py (1 location) Closes leonvanzyl#138 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdds explicit UTF-8 encoding and error replacement parameters to subprocess invocations across three initialization and startup modules to resolve Windows CP1252 encoding issues. No control flow changes; parameters ensure robust text I/O handling on Windows environments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rudiheydra
added a commit
to rudiheydra/AutoBuildr
that referenced
this pull request
Feb 2, 2026
…toForgeAI#139) Align the final_verdict enum values with the app spec (passed|failed|error). The implementation previously used 'partial' instead of 'error'. Changes: - api/agentspec_models.py: VERDICT constant and column comment - server/schemas/agentspec.py: VERDICTS Literal type and validator - api/validators.py: Verdict determination logic in AcceptanceGate - api/harness_kernel.py: Verdict logic in _run_acceptance_validators and _run_partial_acceptance_validators - api/agentspec_crud.py, api/migration_flag.py, api/event_recorder.py: Docstring updates - ui/src/lib/types.ts: AgentRunVerdict TypeScript type - Updated all test assertions from 'partial' to 'error' - All 3488 existing tests continue to pass (no regressions) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rudiheydra
added a commit
to rudiheydra/AutoBuildr
that referenced
this pull request
Feb 2, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8"anderrors="replace"to all subprocess calls that usetext=TrueProblem
Windows users experience
UnicodeDecodeErrorwhen running parallel mode becausesubprocess.Popenwithtext=Truedefaults to CP1252 encoding instead of UTF-8.Solution
Explicitly specify UTF-8 encoding for all subprocess calls that process text output from Claude agents.
Files Modified
parallel_orchestrator.py(3 locations)start.py(2 locations)start_ui.py(1 location)Testing
ruff check parallel_orchestrator.py start.py start_ui.pyNotes
quality_gates.py,git_workflow.py,review_agent.py, andsecurity_scanner.pymentioned in issue Encoding issue with CP1252 / UTF-8 #138 don't exist on master - they are only in feature branches. This PR fixes all affected files on master.Closes #138
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.