-
-
Notifications
You must be signed in to change notification settings - Fork 5
impl Frame & Notebook
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AustinJ235
wants to merge
18
commits into
master
Choose a base branch
from
widgets-ext-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert widget example to use `Frame` as the main container. - Fix scrolling with floating positions. - Add `StyleUpdateBatch` as an alternative to `Bin::style_update_batch`. - Move some fields out of properites of scroll bar that didn't belong. - impl placement updates for scroll bar.
b535a35 to
069f82e
Compare
Added method `TextBodyGuard::overflow`. Fixed bug where the old style was being used for `TextBodyGuard::update_layout`. This required some refactoring of `Bin::calc_placement` to allow using a provided style versus the current one.
- Sensibly handle case when a parentless floating bin somehow makes it past validation. - Fix wrong vertex type for glyph subpixel mask though it currently isn't used. - Added `on_change` & `set_filter` to `TextEntry`. - Change how attachment alpha blending works to properly blend with the user renderer. This may have broken other things, hopefully not. - Added `associated_root_bins` method to `Window`.
…on_change callback of TextEntry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameas the main container.StyleUpdateBatchas an alternative toBin::style_update_batch.