photoproc: replace fopen(), fread(), fgets() with mmap()#360
Open
GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
Open
photoproc: replace fopen(), fread(), fgets() with mmap()#360GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
GermanAizek wants to merge 1 commit intoAtoptool:masterfrom
Conversation
Affected functions: - procstat - procstatus - procio - proccmd - procwchan - procsmaps - procschedstat References: - https://unix.stackexchange.com/questions/474926/how-does-memory-mapping-a-file-have-significant-performance-increases-over-the-s
Contributor
|
@GermanAizek do you have any performance measurements that show the benefits of this change? The linked articles talk about saving buffer copies when reading from disk-backed filesystems, but procfs is not that - its all memory copying only so I'm curious whether this is actually a measurable difference for memory mapping procfs files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mmap() for Zero-copy and Demand Paging
Affected functions:
References: