feat: replace action tokenizer with windowed attention#16
Open
imitation-alpha wants to merge 1 commit intoAlmondGod:mainfrom
Open
feat: replace action tokenizer with windowed attention#16imitation-alpha wants to merge 1 commit intoAlmondGod:mainfrom
imitation-alpha wants to merge 1 commit intoAlmondGod:mainfrom
Conversation
93ed906 to
05765b0
Compare
Owner
|
this looks great! can you train a working world model to confirm the impact of the change? |
|
Sorry to interrupt. I am not an expert, but I am curious if there are "KPIs" to be monitored to evaluate the impact of a change?
|
Owner
yes, I'll add in a readme pr section specifying necessary criteria |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the "mean pool + concat" mechanism in the
LatentActionsEncoderwith a "length-2 windowed attention + mean" mechanism. This change aims to better capture temporal dependencies between adjacent frames during action tokenization.Changes
models/latent_actions.py:SpatialAttentionfrommodels.st_transformer.LatentActionsEncoderto useSpatialAttentionon concatenated windows of current and next frames.Verification
scripts/verify_latent_actions.py- deleted after verification).Notes
LatentActionsEncodercheckpoints.