Skip to content

Prepare repo for PyPI packaging#51

Open
ahmedsobeh wants to merge 7 commits intomainfrom
prepare-repo-for-packaging
Open

Prepare repo for PyPI packaging#51
ahmedsobeh wants to merge 7 commits intomainfrom
prepare-repo-for-packaging

Conversation

@ahmedsobeh
Copy link

About this change - What it does

This PR prepares the repo for packaging on PyPI. the file hierarchy is changed and setup.cfg, setup.py and a new folder for packaging have been added.

Why this way

this is the typical method to package a python package on PyPI.

@ftisiot
Copy link
Collaborator

ftisiot commented Jun 26, 2023

Hi @ahmedsobeh, thanks for this... one question... when I run:

python aiven_metadata_parser/main.py

I get

File "/Users/francescotisiot/Documents/GitHub/metadata-parser/aiven_metadata_parser/main.py", line 2, in <module>
    from aiven_metadata_parser import explore_service
ModuleNotFoundError: No module named 'aiven_metadata_parser'

Should the

from aiven_metadata_parser import explore_service
from aiven_metadata_parser import pyvis_display as pyvis_display

be

import explore_service
import pyvis_display as pyvis_display

?

@@ -24,15 +24,15 @@ The `create_services.sh` uses:
Before starting it, please install the required dependences, login with the [Aiven CLI](https://github.com/aiven/aiven-client) and execute:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth explaining that one can use pip install -r aiven_metadata_parser/requirements.txt to install the Python packages (perhaps in the list item that mentions that file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's mentioned in line #46 already

@ahmedsobeh
Copy link
Author

Hi @ahmedsobeh, thanks for this... one question... when I run:

python aiven_metadata_parser/main.py

I get

File "/Users/francescotisiot/Documents/GitHub/metadata-parser/aiven_metadata_parser/main.py", line 2, in <module>
    from aiven_metadata_parser import explore_service
ModuleNotFoundError: No module named 'aiven_metadata_parser'

Should the

from aiven_metadata_parser import explore_service
from aiven_metadata_parser import pyvis_display as pyvis_display

be

import explore_service
import pyvis_display as pyvis_display

?

Thanks for the commit! Just saw your comment now

Co-authored-by: Tibs (Tony Ibbs) <tony.ibbs@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants