Open
Conversation
Collaborator
|
Hi @ahmedsobeh, thanks for this... one question... when I run: I get Should the be ? |
TibsAtWork
reviewed
Jun 26, 2023
TibsAtWork
reviewed
Jun 26, 2023
| @@ -24,15 +24,15 @@ The `create_services.sh` uses: | |||
| Before starting it, please install the required dependences, login with the [Aiven CLI](https://github.com/aiven/aiven-client) and execute: | |||
Contributor
There was a problem hiding this comment.
Might be worth explaining that one can use pip install -r aiven_metadata_parser/requirements.txt to install the Python packages (perhaps in the list item that mentions that file)
Author
Thanks for the commit! Just saw your comment now |
Co-authored-by: Tibs (Tony Ibbs) <tony.ibbs@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This PR prepares the repo for packaging on PyPI. the file hierarchy is changed and setup.cfg, setup.py and a new folder for packaging have been added.
Why this way
this is the typical method to package a python package on PyPI.