Skip to content

Conversation

@rhino1998
Copy link
Contributor

@rhino1998 rhino1998 commented Jan 26, 2026

This adds support for nested named and unnamed types with parameters like

    Tuple()
    Tuple(String, Int64)
    Tuple(String, Tuple(String, String))
    Tuple(a String, cd Tuple(c String, d String))

@coveralls
Copy link

coveralls commented Jan 26, 2026

Pull Request Test Coverage Report for Build 21455807828

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 68 of 93 (73.12%) changed or added relevant lines in 1 file are covered.
  • 790 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 51.521%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 68 93 73.12%
Files with Coverage Reduction New Missed Lines %
parser/parser_alter.go 54 72.97%
parser/ast.go 736 40.61%
Totals Coverage Status
Change from base Build 21280479720: 0.2%
Covered Lines: 8112
Relevant Lines: 15745

💛 - Coveralls

@git-hulk git-hulk self-requested a review January 26, 2026 10:18
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhino1998 Thanks for your contribution. Left two naming suggestions.

@git-hulk git-hulk merged commit 078beb4 into AfterShip:master Jan 29, 2026
1 check passed
@git-hulk
Copy link
Member

@rhino1998 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants