-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore: add EditorConfig, Nix flake, and update dependencies #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
….10) Signed-off-by: Farhan Kurnia Pratama <farhnkrnapratma@gmail.com>
Signed-off-by: Farhan Kurnia Pratama <farhnkrnapratma@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces development tooling improvements and updates core dependencies for the AerynOS documentation site. It adds EditorConfig for consistent code formatting across editors, establishes a Nix flake for reproducible development environments, updates Astro to v5.16.10 and Starlight to v0.37.3, and creates the directory structure for Indonesian documentation.
Changes:
- Add EditorConfig with standardized formatting rules (UTF-8, 2-space indentation, LF line endings)
- Add Nix flake for reproducible development environment with pnpm and Node.js
- Update Astro from v5.16.8 to v5.16.10 and Starlight from v0.37.2 to v0.37.3
- Create Indonesian (id) docs directory with .gitkeep placeholder
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .editorconfig | Defines consistent code formatting rules for all files |
| flake.nix | Nix flake configuration for development shell with pnpm and Node.js |
| flake.lock | Lock file for Nix flake dependencies |
| package.json | Updates Astro and Starlight dependencies to latest versions |
| pnpm-lock.yaml | Updated lock file reflecting new dependency versions |
| src/content/docs/id/.gitkeep | Placeholder for Indonesian documentation directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
So, I see no benefit to adding NIX specific files since no one here uses NIX and unlike your PR suggests I don't see you've added a folder for the language or that you've tested updating Astro or Starlight please take a look here https://aerynos.dev/packaging/workflow/submitting-a-pr/ editorconfig maybe useful but for such a change open a discussion |
Changes