Queues - Andrea Valliere & Kaitlin Ramirez - VideoStoreAPI#9
Open
avalliere wants to merge 18 commits intoAda-C7:masterfrom
Open
Queues - Andrea Valliere & Kaitlin Ramirez - VideoStoreAPI#9avalliere wants to merge 18 commits intoAda-C7:masterfrom
avalliere wants to merge 18 commits intoAda-C7:masterfrom
Conversation
…rs now rendering with movies_checked_out_count
Video StoreWhat We're Looking For
Good work overall! |
miriam-cortes
left a comment
miriam-cortes
left a comment
There was a problem hiding this comment.
nice job! Leah and I worked together (that's why you won't see comments from her screen name)
| validates :name, presence: true | ||
|
|
||
| def movies_count | ||
| return 0 |
There was a problem hiding this comment.
not sure what this method is doing. Why should it always return 0?
| has_many :rentals | ||
| has_many :customers, :through => :rentals | ||
| validates :title, presence: true | ||
|
|
There was a problem hiding this comment.
Leah says she doesn't like these two spaces here, you might as well delete :)
| <head> | ||
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
| <style> | ||
| /* Email styles need to be inline */ |
There was a problem hiding this comment.
get out of the habit of leaving comments in your code...it will help you during internship 🙄 (bc I do the same)
| Rails.application.routes.draw do | ||
| get "customers", to: "customers#index", as: "customers" | ||
| get "movies", to: "movies#index", as: "movies" | ||
| get "movies/:title", to: "movies#show", as: "movie" |
There was a problem hiding this comment.
awesome job of keeping them dry :)
| end | ||
| end | ||
|
|
||
| # describe "show" do |
There was a problem hiding this comment.
if you don't need this just delete
| @@ -0,0 +1,50 @@ | |||
| require "test_helper" | |||
|
|
|||
| describe MoviesController do | |||
| end | ||
|
|
||
| # No customer show per READ ME | ||
| # def show |
There was a problem hiding this comment.
delete any code you're not using
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video Store API
Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Comprehension Questions
get "customers"get "movies"get "movies/:title"