Queues - Sahana Murthy - Random Menu #28
Open
sahanamurthy wants to merge 1 commit intoAda-C7:masterfrom
Open
Conversation
droberts-sea
left a comment
droberts-sea
left a comment
There was a problem hiding this comment.
Random Menu
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Random Menu of 10 items displayed in the terminal. | Yes |
| Generator pulls one random item from each array to create menu items. | Yes |
| Readable code with consistent indentation. | Yes |
| Extras | |
| Menu components are not repeated | Yes |
| User can specify how many menu items to see | Yes |
Excellent work overall!
| # Generate random Menu | ||
| # Delete items from arrays so they cannot be used again | ||
| if user_input <= 10 | ||
| user_input.times { |n| |
There was a problem hiding this comment.
In this class, we'll encourage you to use do...end instead of curly braces. They function the same, but I think do...end is more legible.
| # Delete items from arrays so they cannot be used again | ||
| if user_input <= 10 | ||
| user_input.times { |n| | ||
| puts "#{ n + 1 }. #{adjective = array_adjective.sample} #{style = array_style.sample} #{food = array_food.sample}" |
There was a problem hiding this comment.
I like the idea of storing the chosen menu components in variables and then removing them from the lists. However, assigning a variable inside of a string interpolation is a little hard to read. Could clean this up by breaking it into multiple lines?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random Menu
Congratulations! You're submitting your assignment.
Comprehension Questions