Skip to content

Add support data caching to CI#1296

Open
ReeceHumphreys wants to merge 5 commits intodevelopfrom
ci/cache-bsk-data
Open

Add support data caching to CI#1296
ReeceHumphreys wants to merge 5 commits intodevelopfrom
ci/cache-bsk-data

Conversation

@ReeceHumphreys
Copy link
Contributor

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR adds a new environment variable that allows for overriding the default Pooch cache location. We can now use this in CI to set a persistent cache for the support data files so they do not need to be fetched every time. This cache has been set with a biweekly expiration policy to avoid the data from becoming too stale.

Verification

CI

Documentation

Add a section explaining how to set the env var.

Future work

N/A

@ReeceHumphreys ReeceHumphreys self-assigned this Feb 27, 2026
@ReeceHumphreys ReeceHumphreys added the ci Continuous integration label Feb 27, 2026
@ReeceHumphreys ReeceHumphreys marked this pull request as ready for review February 27, 2026 16:54
@ReeceHumphreys ReeceHumphreys requested a review from a team as a code owner February 27, 2026 16:54
@ReeceHumphreys ReeceHumphreys moved this to 👀 In review in Basilisk Feb 27, 2026
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. This will hopefully ease file server access issues.

@schaubh
Copy link
Contributor

schaubh commented Feb 27, 2026

On your branch caching the data downloads, Codex tells me:

In each workflow, ./.github/actions/data-cache is executed after ./.github/actions/build (pull-request.yml, pull-request.yml, pull-request.yml, pull-request.yml, merge.yml, canary.yml).
But the build action itself runs bskLargeData during build (build/action.yml).
Because BSK_SUPPORT_DATA_CACHE is only set inside data-cache (data-cache/action.yml), the initial download happens in the default cache path, not .bsk-cache. Result: the new cache is bypassed for the expensive download path and can even cause duplicate downloads later in the same job.

Can you comment on this? It might be on to something.

@ReeceHumphreys
Copy link
Contributor Author

ReeceHumphreys commented Feb 28, 2026

Can you comment on this? It might be on to something.

Fixed as suggested, Codex was correct and it should have been moved a few lines earlier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants