Draft
Conversation
Simaris
force-pushed
the
feature/AtomicGraph
branch
from
70f8a02 to
95a068c
Compare
Simaris
force-pushed
the
feature/AtomicGraph
branch
from
5c1ca51 to
de8b125
Compare
Simaris
force-pushed
the
feature/AtomicGraph
branch
from
de8b125 to
6a7a278
Compare
Simaris
force-pushed
the
feature/AtomicGraph
branch
from
12fc1c8 to
e5c5ff2
Compare
…the same BlankNode
Simaris
force-pushed
the
feature/AtomicGraph
branch
from
e5c5ff2 to
6bc4b6e
Compare
Member
|
Just as a link: RDFLib/rdflib#1294 |
| try: | ||
| (f, context, nameMap) = result | ||
| except ValueError: | ||
| print(result) |
Collaborator
There was a problem hiding this comment.
Is the error actually handled?
| self._merge_test(join(testPath, d), "context") | ||
|
|
||
| def _merge_test(self, dirPath, method): | ||
| # Prepate a git Repository |
| self._blobs.set(blob, (file_reference, context, nameMap)) | ||
| blobs_new.add(blob) | ||
| except KeyError: | ||
| pass |
Collaborator
There was a problem hiding this comment.
Error actually handled?
| @@ -413,17 +423,74 @@ def getFileReferenceAndContext(self, blob, commit): | |||
| content = commit.node(path=name).content | |||
Collaborator
There was a problem hiding this comment.
if blob in self._blobs:
return self._blobs.get(blob)
else
...
return quitWorkingData| A BNode('a') found in parsedQuery would be replaced by the blanknode _:a found in the graph.nt. | ||
| That way, updates can pass Blanknodes as instances and do not have to work on string representations. | ||
| """ | ||
| def replaceBlankNode(parsedQuery, nameMap): |
Collaborator
There was a problem hiding this comment.
Very very big: three for loops and four ifs, try to split in multiple functions and maybe use list comprehension for more conciseness.
|
|
||
| if len(nameMap) == 0: | ||
| return | ||
| for change in changes: |
Collaborator
There was a problem hiding this comment.
Also too deep, difficult to understand.
| len((c for c in self.graphs() if c not in self.store.contexts())) | ||
| ) | ||
|
|
||
| #def update(self, update_object): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.