Open
Conversation
|
Can we merge this into the master? Need support for selenium 3.11.0 |
|
How do we fix the build issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We updated to selenium-java 3.3.1 which is used together with Winium.Desktop to run our Windows automation. Unfortunately the recent selenium version (>=3.3) is not compatible with Winium.Desktop anymore, because it lacks some webdriver commands that are now needed. I added implementation for the two commands to make it run again:
The implementation of
setTimeoutis just a stub and return null (which is a valid return value, but will not change the behavior). Maybe that can be changed in a later update.