Skip to content

Fix tests for V1.2.0#8

Open
AkaP88 wants to merge 3 commits into0xfdf:v1.1.2from
AkaP88:v1.1.2
Open

Fix tests for V1.2.0#8
AkaP88 wants to merge 3 commits into0xfdf:v1.1.2from
AkaP88:v1.1.2

Conversation

@AkaP88
Copy link

@AkaP88 AkaP88 commented Aug 23, 2024

Added :

  • Fix for model_sample_data()
  • Parameter not passed to winsorize in estimate_factor_returns
  • A (bad) support for an unsupported exceptions in polars causing a panic
  • Winsorize_group return type

@AkaP88
Copy link
Author

AkaP88 commented Aug 23, 2024

@0xfdf : I tried to contribute to your PR of V1.2.0 but could not commit on top of it. Let me know if I could have done differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant