feat(web-client): migrate all tutorials to MidenClient API#164
Open
WiktorStarczewski wants to merge 11 commits intomainfrom
Open
feat(web-client): migrate all tutorials to MidenClient API#164WiktorStarczewski wants to merge 11 commits intomainfrom
WiktorStarczewski wants to merge 11 commits intomainfrom
Conversation
…terals with enum references
…Client API - Replace WebClient with MidenClient.create() - Replace syncState() with sync() - Replace newWallet/newFaucet with client.accounts.create() - Replace manual tx request builders with client.transactions.mint/consume/send/submit() - Replace getConsumableNotes() with client.notes.listAvailable() - Pass account objects directly instead of .id() to transaction methods - Use NoteVisibility enum instead of 'public' string literals - Update React files to pass account objects instead of string IDs
…cript code snippets
WiktorStarczewski
changed the title
WiktorStarczewski
changed the title
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/*.ts) from the oldWebClientAPI to the newMidenClient0.14 namespaced API (client.accounts.*,client.transactions.*,client.notes.*,client.compile.*)incrementCounterContract,foreignProcedureInvocation) to self-containedMidenClientexamples.md) to match the new API patterns in both TypeScript and React code snippetsAccountType,StorageMode,NoteVisibility.id()string IDs, wherever the SDK acceptsAccountRef--disable-web-securityto Playwright config to allow browser→RPC requests in headless tests- Switches tutorial RPC endpoint to local node (
http://localhost:57291) for E2E testsNot sure whether to merge it with local node for unstable docs, and change on release of 0.14? wdyt @Keinberger
Test plan
createMintConsume— passesmultiSendWithDelegatedProver— passesincrementCounterContract— passesunauthenticatedNoteTransfer— passesforeignProcedureInvocation— passes