fix: resolve timingSafeEqual infinite recursion bug#63
Open
Conversation
The exported timingSafeEqual function shadowed the imported crypto.timingSafeEqual, causing infinite recursion when called. Renamed the export to timingSafeHashEqual and the import to cryptoTimingSafeEqual to avoid the naming collision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix infinite recursion bug in
plugins/repo-mode-launch/lib/hashing.ts.The exported
timingSafeEqualfunction shadowed the importedcrypto.timingSafeEqual, causing the function to call itself recursively instead of the Node.js crypto implementation. This results in a stack overflow whenever hash comparison is attempted.Changes
cryptoimport tocryptoTimingSafeEqualto avoid shadowingtimingSafeHashEqualfor claritycrypto.timingSafeEqualImpact
Runtime crash — any code path calling
timingSafeEqualfrom this module would hit infinite recursion and crash with a stack overflow.Tested
timingSafeEqualfromhashing.ts(onlyrepo-attestation.tsandnaming.tsimport other functions)