fix: resolve timingSafeEqual infinite recursion + correct repo URLs#61
Open
fix: resolve timingSafeEqual infinite recursion + correct repo URLs#61
Conversation
0xAxiom
force-pushed
the
fix/timing-safe-equal-recursion
branch
from
074f122 to
f116ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix critical timingSafeEqual infinite recursion bug in plugins/repo-mode-launch/lib/hashing.ts - the exported function shadows the crypto import, causing stack overflow at runtime. Renamed import to cryptoTimingSafeEqual.
Fix repository URL mismatch in package.json - repository.url and bugs.url pointed to 0xAxiom/AppFactory (fork) instead of MeltedMindz/AppFactory (canonical).
Why
Tested