fix: read cli version from package.json instead of hardcoding#54
Open
fix: read cli version from package.json instead of hardcoding#54
Conversation
the cli version was hardcoded as '1.0.0' in the commander .version() call, which would always report 1.0.0 regardless of the actual package version. now reads from CLI/package.json at startup for accurate version reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--versionflag now reads fromCLI/package.jsoninstead of hardcoding'1.0.0'Why
The CLI version was hardcoded as
'1.0.0'in the commander.version()call on line 46 ofCLI/src/index.ts. This meansappfactory --versionwould always report1.0.0regardless of the actual version inpackage.json(currently1.0.0, but would drift on any version bump).Reading from
package.jsonat startup is the standard pattern (used by commander's own docs) and ensures the reported version always matches the package.Tested
npx tsc --noEmitpasses (CLI type-checks clean)