Add the associated fragments to the found graphql-nodes #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdba920 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Nov 11, 2025
| pokemon(id: $id) { | ||
| id | ||
| fleeRate | ||
| ...Pok |
Member
Author
There was a problem hiding this comment.
This now correctly shows an error
JoviDeCroock
commented
Nov 11, 2025
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 9 | ||
| version: 8.6.1 |
Member
Author
There was a problem hiding this comment.
This was not in line with the regular ci
JoviDeCroock
force-pushed
the
missing-fragments-in-array
branch
3 times, most recently
from
fdc7a98 to
e9b50b0
Compare
kitten
approved these changes
Nov 11, 2025
JoviDeCroock
force-pushed
the
missing-fragments-in-array
branch
from
9d6e6c4 to
7e7978c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 0no-co/gql.tada#494
Currently we see Fragments defined within one files GraphQL invocation as determining to what we'll use for all invocations within that file. This means that the fragments will leak into one another, the PR effectively adds the fragments of each node within the array so that we can use them more granularly.
In addition this contains a drive-by fix for projects in migration paths to not leverage global fragments from graphql-code-generator in gql.tada