From c60f7c674391acebe92042a2ad5402cdc63b9dd8 Mon Sep 17 00:00:00 2001 From: SamW94 Date: Fri, 16 Jan 2026 15:46:27 +0000 Subject: [PATCH 1/2] feat: remove requirement for a steward to be named --- SECURITY_CHECKLIST.md | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/SECURITY_CHECKLIST.md b/SECURITY_CHECKLIST.md index d155753..fa680e4 100644 --- a/SECURITY_CHECKLIST.md +++ b/SECURITY_CHECKLIST.md @@ -16,7 +16,6 @@ This checklist is designed to make it easier to improve the security posture of - [ ] [Copy the SECURITY_CHECKLIST.md file](#copy-the-security_checklistmd-file) - [ ] [Review the GitHub CI/CD overview](#review-the-github-cicd-overview) - [ ] [Review the GitHub Safety Tips](#review-github-safety-tips) -- [ ] [Add Steward to Repository access](#add-at-least-one-steward-to-repository-access) - [ ] [Create an admin team for the repository](#create-an-admin-team-for-the-repository) - [ ] [Review and limit maintainers with admin rights to the strict minimum](#review-and-limit-maintainers-with-admin-rights-to-the-strict-minimum) - [ ] [Review the Pull Request template](#review-pull-request-template) @@ -103,16 +102,6 @@ In addition to adding at least one Steward, a new team with the admin role must 10. On the next screen, choose the `Admin` role 11. Click the `Add selection` button to complete the process -## Add at least one steward to repository access - -To add a steward to a repository: - -1. Open the `Collaborators and teams` settings page. The url for this is `https://github.com/uktrade/REPO_NAME/settings/access` -2. Use the `Add people` button to open the people finder autocomplete box. -3. Find and click the user who is going to be a steward -4. On the Choose a role page, select the `Steward` role. -5. Repeat for any additional users who are going to be a steward - ## Review and limit maintainers with admin rights to the strict minimum You should review who has been assigned the github `admin` role. The `write` role is sufficient to allow team members to commit changes and raise pull requests From 1731baa0b8c2737837b558340995b74fb51f9832 Mon Sep 17 00:00:00 2001 From: SamW94 Date: Fri, 16 Jan 2026 15:49:41 +0000 Subject: [PATCH 2/2] feat: use pull_request_template Signed-off-by: DBT pre-commit check --- .github/pull_request_template.md | 41 ++++++++++++++++---------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e509871..2bb4247 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,30 +1,31 @@ - +# Description -## What +Please include a summary of the changes and the related issue including relevant motivation and context. Please also include a link to the corresponding JIRA ticket this merge request addresses. - +## Contributors -## Why +Let's acknowledge the people who contributed to the work. - +## Type of change + +- [ ] Refactoring (made code better without changing its behaviour) +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## How this has been tested -- [ ] I have tested locally -- [ ] Testing not required +Please describe the tests that you ran to verify your changes. + +If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced. + +## Checklist + +- [ ] I have performed a self-review of my code +- [ ] I have commented my code in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes generate no new warnings ## Reviewer Checklist -- [ ] I have reviewed the PR and ensured no secret values are present +- [ ] I have reviewed the PR and ensured no secret values are present \ No newline at end of file