Skip to content

Refactor Phylotyper Integration #311

@kevinkle

Description

@kevinkle

@mwhitesi raised some good points about #309
We've currently hotfixed it for now, but here are Matt's points for a future refactor.

Does order matter? i.e. the phylotyper ontology graph is created before linking it to the results graph and its also created before checking if the loci exist. Not sure if building edges during the phylotyper ontology graph construction will add empty `:stx2a`, `:stx2b` nodes. I would check for the existence of the marker loci before creating the MarkerSequences object and going to the trouble of building the phylotyper ontology

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions