Skip to content

ApplyTransform.Warp.run() alters the TransformsList such that it can't be used again #1866

@mattcai

Description

@mattcai

Description

Sometimes, starfish users may want to apply a TransformsList to multiple ImageStacks with ApplyTransform.Warp. For example, applying the same transforms to both dapi and primary ImageStacks. The issue is that TransformsList gets modified when used by ApplyTransform.Warp such that the next time it is used by ApplyTransform.Warp it can return erroneous results or throws an error.

A quick workaround is to only use each TransformsList once, and re-LearnTransform if needed.

Steps/Code to Reproduce

transforms bug gist

Expected Results

The transforms printed before and after Warp.run() are the same. No error is thrown on the second Warp.run().

Actual Results

Before:
tile indices: {<Axes.ROUND: 'r'>: 0}
translation: y=0.0, x=0.0, rotation: 0.0, scale: 1.0
tile indices: {<Axes.ROUND: 'r'>: 1}
translation: y=-102.126, x=194.721, rotation: 0.0, scale: 1.0
tile indices: {<Axes.ROUND: 'r'>: 2}
translation: y=-190.79, x=120.938, rotation: 0.0, scale: 1.0

After:
tile indices: {<Axes.ROUND: 'r'>: 0, <Axes.CH: 'c'>: 2, <Axes.ZPLANE: 'z'>: 0}
translation: y=0.0, x=0.0, rotation: 0.0, scale: 1.0
tile indices: {<Axes.ROUND: 'r'>: 1, <Axes.CH: 'c'>: 2, <Axes.ZPLANE: 'z'>: 0}
translation: y=-102.126, x=194.721, rotation: 0.0, scale: 1.0
tile indices: {<Axes.ROUND: 'r'>: 2, <Axes.CH: 'c'>: 2, <Axes.ZPLANE: 'z'>: 0}
translation: y=-190.79, x=120.938, rotation: 0.0, scale: 1.0

KeyError thrown.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugAn issue with an existing feature

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions